Donald Trump was the latest commander-in-chief to raise regal eyebrows on his state visit to Windsor Castle this week.